Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

955 improve performance #973

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Aug 31, 2023

Improve RSD v2 performance

Closes #955

Changes proposed in this pull request:

  • loading mentions on the software and project page api is changed to more performant api requests. (reduced from ~300ms to ~50ms)
  • auth endpoint response is improved to cache the list of login providers on initial load instead of reading it on each request (reduced from ~500ms to ~10ms after initial request).
  • fix cumulative layout shift on software overview page when highlights section is used
  • bump the node version to v20 in the fe image. Node v20 is going to be LTS version from October 2023, so we should switch from v18 to v20 asap. Advice to FE developers, use nvm to manage multiple node versions on your machine.
  • apply fixes advised by Lighthouse audit: increase image cache to 1yr and provide width and height for images

How to test:

  • The improvement cannot be tested without comparing it to performance of the previous version.
  • make start to rebuild app
  • Navigate between home, software, organisation and project pages. The loading of the pages should be improved.
  • After merging this PR I will set this version on dev server and perform load testing. Then we can compare the results with the load test results of the previous version. The expectation is that performance should be improved by these changes. I will post the results of load test in rsd-v2-release PR.

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

[rsd-database] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

[rsd-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

44.3% 44.3% Coverage
8.0% 8.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dmijatovic dmijatovic merged commit 07104a4 into rsd-v2-release Sep 1, 2023
6 of 7 checks passed
@dmijatovic dmijatovic mentioned this pull request Sep 1, 2023
4 tasks
@dmijatovic dmijatovic deleted the 955-improve-performance branch September 4, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants